Add an option to add noConflict method to umd global - #580
Merged
Conversation
Contributor
|
Great idea – |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this was even something on the radar for rollup, but it seemed like a better solution than regexp hacking build output. So feel free to ignore this if it's not something rollup should handle 😄
This should only affect UMD modules when they're used as a global. I'm not 100% sure this is the best way to handle it, or if I've even put all the right things in the right places, but I did do a test build with this with Ractive and it seems to work as intended.
Linking - ractivejs/ractive#2066