Skip to content

Partially fix tests on Windows - #6

Closed
Bobris wants to merge 0 commit into
rollup:masterfrom
Bobris:master
Closed

Partially fix tests on Windows#6
Bobris wants to merge 0 commit into
rollup:masterfrom
Bobris:master

Conversation

@Bobris

@Bobris Bobris commented May 27, 2015

Copy link
Copy Markdown
Contributor

There are still unfortunate tests which uses path.relative and asserting result :-( which of course also fails. One of them:
rollup/test/function/shadowed-external-export

@Rich-Harris

Copy link
Copy Markdown
Contributor

Ah, nuisance! Sorry about that. Will of course merge this, but before I do can I ask about the whitespace differences in the test files? I see that it's intentional, I just want to make sure that it's not a change that's going to go back and forth depending on the committer's OS :-)

@Bobris

Bobris commented May 29, 2015

Copy link
Copy Markdown
Contributor Author

Ouch these pesky new lines. Second commit is really bad. I still don't understand newlines at end of files as I didn't saw code which would do it. Please commit only first one. I will study more code to write always "\n" and not platform dependent new lines.

@Bobris

Bobris commented May 30, 2015

Copy link
Copy Markdown
Contributor Author

Removed second commit so it is now easy to merge.

@Rich-Harris

Copy link
Copy Markdown
Contributor

Huh, thanks for closing this - I thought it had auto-closed via merge but apparently I don't know how to git

@Bobris

Bobris commented Jun 5, 2015

Copy link
Copy Markdown
Contributor Author

It took me a while understand that you actually already merged it and cursed git saying me nothing to commit after resolving merge conflict :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants