allow resolved module IDs to be non-strings - #692
Merged
Conversation
Rich-Harris
added a commit
that referenced
this pull request
Jun 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this is to allow plugins like rollup-plugin-commonjs and rollup-plugin-babel to supply 'helper' modules (which transformed modules then depend on) without having to use daft string IDs like
__babelHelpers__and hoping that there are no collisions.The larger goal is to make it easier for to plugins to be stateless, which advances the goal of incremental rebuilds (see #658 (comment)).