Load all modules and syncify - #97
Merged
Merged
Conversation
Contributor
|
This seems great! I've wanted a change like this but been afraid to suggest it. Thought there might have been some clever reason for the lazy-loading. |
Rich-Harris
added a commit
that referenced
this pull request
Aug 24, 2015
Load all modules and syncify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of the plan to address #96 – loading all modules specified by
importstatements, regardless of whether a given module is destined to end up in the bundle. This is a prerequisite for identifying certain side-effects.As a consequence we can rewrite a number of methods to be synchronous (and therefore shorter and easier to read), since we only need the async stuff during the initial loading phase.