handle export default{} - #1218
Merged
Merged
Conversation
jlmakes
added a commit
to jlmakes/scrollreveal
that referenced
this pull request
Jan 6, 2017
This change causes tests to fail, even though bundling has no issues. It's possible there is something odd about karma rollup preprocessor (which I maintain), but it turns out that the bug is easily fixed by updating a regex within Rollup: rollup/rollup#1218 So it appears the next release of Rollup following 0.40.0 will no longer fail tests due to this strange issue with object literal default exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via Gitter