Fix closure memory leak in Bundle constructor - #1470
Merged
Conversation
Rich-Harris
added a commit
that referenced
this pull request
Jul 9, 2017
Contributor
|
You hero! Been scratching my head over this a while — thanks, this is incredibly useful. Have added your gist as a test. |
|
Thank you !!!! |
spencer-brown
pushed a commit
to mixmaxhq/multibuild
that referenced
this pull request
Jul 18, 2017
spencer-brown
added a commit
to mixmaxhq/multibuild
that referenced
this pull request
Jul 18, 2017
Upgrade rollup to pick up rollup/rollup#1470
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #883
"options" argument is captured by closures in Bundle constructor, so passing "cache" leads to chain of bundles in memory.
Similar bug is described here: https://blog.meteor.com/an-interesting-kind-of-javascript-memory-leak-8b47d2e7f156
I've created gist with test script, but don't known how to properly integrate it here.
https://gist.github.com/dmitrage/fff3d30280688356194c137323ea4e02