Let process.stdin actually trigger it’s end event - #1774
Merged
Conversation
Member
|
Reading through the linked issue I think I begin to understand what this is about. Not sure we can automatically test this in some way but I think there is no harm putting this into the next patch release. |
Contributor
|
So this was added not to support stdin for watching, but to ensure the Rollup process can be terminated? If so can this not also be achieved by just setting the This came up again in #2410, where it seems like it is going to be reverted to fix Lerna support. |
Contributor
Author
|
Yes, this was added to ensure rollup is properly terminated once stdin closes. I just don't have a project at hand at the moment to check with the persistent flag. I can try that later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per rollup/rollup-watch#57
Without the added line the previous listener will never be triggered.