Skip to content

fix typescript compiler errors based on emitted d.ts files - #1864

Merged
lukastaegert merged 1 commit into
rollup:masterfrom
unstubbable:fix-ts-issues
Jan 12, 2018
Merged

fix typescript compiler errors based on emitted d.ts files#1864
lukastaegert merged 1 commit into
rollup:masterfrom
unstubbable:fix-ts-issues

Conversation

@unstubbable

@unstubbable unstubbable commented Jan 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #1862

To fix all compiler errors mentioned in #1862 a TypeScript project that imports Rollup additionally needs to add theses devDependencies:

  • @types/chokidar
  • @types/source-map
  • magic-string (brings its own typing)

@unstubbable
fix typescript compiler errors based on emitted d.ts files
d0fef47 
fixes rollup#1862

To fix all compiler errors mentioned in rollup#1862 a TypeScript
project that imports Rollup needs to add theses devDependencies:

- @types/chokidar
- @types/source-map
- magic-string
@lukastaegert lukastaegert mentioned this pull request Jan 12, 2018
Closed
lukastaegert
lukastaegert approved these changes Jan 12, 2018
View reviewed changes

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@lukastaegert lukastaegert added this to the 0.54.0 milestone Jan 12, 2018
@alan-agius4

alan-agius4 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

Hey, firstly thanks for the PR. I downloaded your branch and seems that the errors are still there

node_modules/rollup/dist/typings/Module.d.ts(1,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/Module.d.ts(5,30): error TS2307: Cannot find module 'source-map'.
node_modules/rollup/dist/typings/ast/nodes/BlockStatement.d.ts(3,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/ClassDeclaration.d.ts(4,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/ExportDefaultDeclaration.d.ts(5,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/FunctionDeclaration.d.ts(3,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/Identifier.d.ts(6,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/Property.d.ts(5,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/TemplateLiteral.d.ts(2,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/shared/Node.d.ts(4,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/ast/nodes/shared/Statement.d.ts(2,25): error TS2307: Cannot find module 'magic-string'.
node_modules/rollup/dist/typings/node-entry.d.ts(1,22): error TS6053: File 'C:/git/angular5-dynamic-supress-meta-error/node_modules/rollup/typings/package.json.d.ts' not found.
node_modules/rollup/dist/typings/node-entry.d.ts(6,36): error TS2307: Cannot find module 'package.json'.
node_modules/rollup/dist/typings/rollup/index.d.ts(3,30): error TS2307: Cannot find module 'source-map'.
node_modules/rollup/dist/typings/rollup/index.d.ts(5,27): error TS2307: Cannot find module 'magic-string'.

@lukastaegert
lukastaegert merged commit d0fef47 into rollup:master Jan 12, 2018
@unstubbable unstubbable mentioned this pull request Jan 12, 2018
Merged
@ghost ghost mentioned this pull request Jan 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.54.0

Development

Successfully merging this pull request may close these issues.

TypeScript compilation errors

3 participants

@unstubbable @alan-agius4 @lukastaegert