RFC: add Module.includeAllInBundleRecursive - #1887
Conversation
|
I'm not sure I follow the use case here, is there an issue tracking the feature or further description somewhere? |
|
Expanding upon #1845 (comment), I essentially want to add the module with the missing export to the entry modules. This PR has to be rewritten for the new system, but the use case still remains. I wish this use case didn't have to exist, but it is a interop concern that will hopefully correct itself once we roll this out to Ember users with a warning. Here are a couple of examples I found with my testing: |
|
Does the So if I'm hearing you right, this change is necessary to ensure the missing export hook triggers correctly? I've very concerned that the missing export hook merged exposes the internal //cc @lukastaegert |
|
Also it would help to hear what the exact fix is that you are implementing through the missing export hook. |
|
The pseudo code is As you can see, I don't need any Module API after the chunking change, but I still need a way to continue traversing a broken tree. |
|
Is this PR still valid? |
Uses #1845 as a base to create meaningful tests. That description also perfectly applies here #1845 (comment).