Fix TypeScript test for Windows - #1954
Merged
Merged
Conversation
Instead of renaming `src` (which was quite a brittle approach, as rightfully pointed out by @kzc) we copy `dist` and `typings` into the typescript test directory and import rollup from there. This still ensures that there are no triple slash references in the generated d.ts files to any src files since the relative paths wouldn't be resolvable. fixes rollup#1934
lukastaegert
approved these changes
Feb 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of renaming
src(which was quite a brittle approach to begin with, as rightfully pointed out by @kzc) we copydistandtypingsinto the typescript test directory and import rollup from there. This still ensures that there are no triple slash references in the generatedd.tsfiles to anysrcfiles since the relative paths wouldn't be resolvable.fixes #1934 (since with this solution there is no need to use semi-colons anymore)