Include Required Dependencies Of Rollup In "dependencies" - #1965
Merged
Conversation
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Even though these dependencies might be required for some of the internal TypeScript types to be working correctly, they are by no means necessary for rollup to work because they are already part of the rollup bundle. The question should be rather how to make the types work without those dependencies that users of rollup do not come into contact with anyway.
Member
|
I guess since no better suggestion has been made yet, this will go into the next feature release. |
avgaltsev
added a commit
to avgaltsev/rollup-plugin-postcss-exports
that referenced
this pull request
Mar 8, 2018
This was referenced Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues: