fixes #2033 namespace import reexport case - #2034
Merged
Merged
Conversation
Member
|
One note though on making PRs vs branches other than master: If this is not really necessary I'd rather have the noise in the PR but have it raised against
While if it is raised against master, I can
|
Contributor
Author
|
@lukastaegert this was a one off to deal with (a) failing tests and (b) commit noise from an added commit hook that was modifying all PRs to make them harder to review. Correcting these issues created by others took me an hour. The least you can do is deal with a slightly different rebase process. |
This was referenced Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2033.
Again, rebased to prettier and Rollup update PRs to ensure passing tests and noise-free diff!