A few performance improvements - #2052
Merged
Merged
Conversation
lukastaegert
approved these changes
Mar 14, 2018
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Great work! Even though it may only be a moderate improvement overall, sourcemap generation is now around 45% faster while your changes to the loops alone improved tree-shaking performance by 25%. I hope to find some time soon to tackle the proto issue soon but this is really moving us forward in a great direction!
Member
|
@guybedford I assume there is no objection from your side if I put this into the next release? |
This was referenced Mar 15, 2018
This was referenced Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor optimizations:
sourcemap-codecto an optimized version (see Massive performance improvements Rich-Harris/sourcemap-codec#71)With this PR, Mapbox GL JS bundle is about 10-12% faster (from 9.5s to 8.5s).