Simplify namespace interop - #2136
Merged
Merged
Conversation
lukastaegert
approved these changes
Apr 18, 2018
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Great improvement, also makes the code so much nicer!
Member
|
Great! This fixes an issue with different ways to import react import React from 'react';import * as React from 'react'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2081 allowing external modules imported as both default and namespaces can still have default interop applied to them in the default import case (matching the AMD, IIFE and UMD interop cases to CommonJS in the process).
This replaces #2080, while including a lot of simplification in the interop handling code.