Skip to content

Add badge to display install size - #2196

Merged
lukastaegert merged 1 commit into
rollup:masterfrom
styfle:patch-1
May 21, 2018
Merged

Add badge to display install size#2196
lukastaegert merged 1 commit into
rollup:masterfrom
styfle:patch-1

Conversation

@styfle

@styfle styfle commented May 18, 2018

Copy link
Copy Markdown
Contributor

This adds a badge to the README.md that displays the npm install size

@styfle

styfle commented May 18, 2018

Copy link
Copy Markdown
Contributor Author

How can travis fail if I only changed the README.md file?

Anything I need to do here?

@lukastaegert

Copy link
Copy Markdown
Member

No, this is an issue that happens at times. Not sure why, I hope we get to the bottom of this at some point, restarting CI solved the issue.

I like the idea but the link in the badge does not seem to load for me. Will try again tomorrow.

@styfle

styfle commented May 20, 2018

Copy link
Copy Markdown
Contributor Author

@lukastaegert Thanks for restarting the CI, it seems we are both having problems 😇

I had to redeploy Package Phobia (I guess it's getting a lot a traffic now which is good).

The link should work now 👍 https://packagephobia.now.sh/result?p=rollup

@lukastaegert

Copy link
Copy Markdown
Member

Looks really nice, thanks a lot! Will add this to our readme, I guess Rollup's small install footprint is something we could definitely promote a little better 😜

@lukastaegert
lukastaegert merged commit 5c9a059 into rollup:master May 21, 2018
@lukastaegert lukastaegert added this to the 0.60.0 milestone May 21, 2018
@styfle
styfle deleted the patch-1 branch May 21, 2018 18:19
@styfle

styfle commented May 21, 2018

Copy link
Copy Markdown
Contributor Author

Thanks! 🎉

Rollup's small size is definitely a selling point when compared with webpack or browserify.

@revelt

revelt commented May 27, 2018

Copy link
Copy Markdown

To add a two-pence, rollup is a dev-dependency so sizes don't really matter because it does not end up bundled in the production code. But, as they say, the more badges the better! 👍

@vladshcherbin

Copy link
Copy Markdown
Contributor

Really interesting, why this badge is even needed since it's a dev dependency.

@lukastaegert

Copy link
Copy Markdown
Member

The badge has nothing to do with you creating small bundles or dependencies or whatever you create but this is about keeping your node_modules folder small and clean. There are people who care about this even if it is not you nor even a majority.

Just imagine you put this on a server or inside a docker container. Or for a more common situation in professional software development that I personally experienced, you have CI system that is not capable of caching your npm installs due to e.g. sandboxing. In this situation, it can be a noticeable improvement to your build pipeline time if you do not have to install 82MB of dev dependencies as you have to for e.g. parcel.

So please, yes, we know how npm install works, no reason to point out the obvious 🙄

@vladshcherbin

Copy link
Copy Markdown
Contributor

@lukastaegert no pointing intended, just interested in use cases. Thanks for the explanation 😉

@revelt

revelt commented May 31, 2018

Copy link
Copy Markdown

@styfle good job by the way! I just noticed it's yours

@styfle

styfle commented May 31, 2018

Copy link
Copy Markdown
Contributor Author

@lukastaegert Excellent points!

@revelt Thanks for the kind words!

The readme has a pretty thorough description of why Package Phobia exists and how it’s different than other similar projects: https://github.com/styfle/packagephobia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants