Fix plugin regressions - #2246
Merged
Merged
Conversation
Contributor
Author
|
(also included a closure fix for the chunk.id handling, which must be read synchronously) |
guybedford
force-pushed
the
ongenerate-fix
branch
from
June 6, 2018 20:34
2bd9c74 to
fbde57e
Compare
Contributor
Author
|
Updated to include a fix for #2247 as well |
lukastaegert
approved these changes
Jun 7, 2018
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Awesome quick fixes here. Will do a release shortly.
| return inputOptions.plugins.reduce(applyOptionHook, inputOptions); | ||
| inputOptions = inputOptions.plugins.reduce(applyOptionHook, inputOptions); | ||
|
|
||
| if (!inputOptions.experimentalCodeSplitting) { |
Member
There was a problem hiding this comment.
Makes a lot more sense to do these checks after plugins have been applied 👍
guybedford
referenced
this pull request
in tivac/modular-css
Jun 10, 2018
It's sort of a hack but works around rollup tree-shaking away the CSS imports (since they aren't technically being used by the JS code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.