Skip to content

System uninitialized bindings cases - #2258

Merged
lukastaegert merged 1 commit into
masterfrom
system-uninitialized
Jun 13, 2018
Merged

System uninitialized bindings cases#2258
lukastaegert merged 1 commit into
masterfrom
system-uninitialized

Conversation

@guybedford

@guybedford guybedford commented Jun 10, 2018

Copy link
Copy Markdown
Contributor

This fixes #2257, providing exports both for uninitialized variables and exported globals.

When there is just a single export, an exports('name', binding) is emitted, and when there are multiple, the object form of export is used instead.

@guybedford guybedford changed the title System uninitialized exports failing test System uninitialized bindings cases Jun 11, 2018
@guybedford
guybedford force-pushed the system-uninitialized branch from 17384e7 to f9b6a53 Compare June 11, 2018 12:22
@guybedford

Copy link
Copy Markdown
Contributor Author

I've updated this PR with the fix using the UNDEFINED_EXPRESSION handling in variables.

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, minimal fix!

@lukastaegert lukastaegert added this to the 0.60.4 milestone Jun 13, 2018
@lukastaegert
lukastaegert force-pushed the system-uninitialized branch from f9b6a53 to 2d15b4d Compare June 13, 2018 06:52
@lukastaegert
lukastaegert merged commit 2d15b4d into master Jun 13, 2018
@lukastaegert
lukastaegert deleted the system-uninitialized branch June 13, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System module format undefined init expressions

2 participants