Skip to content

Use primitive string type in TransformHook - #2269

Merged
lukastaegert merged 1 commit into
rollup:masterfrom
dmitrage:transform-hook-typings
Jun 14, 2018
Merged

Use primitive string type in TransformHook#2269
lukastaegert merged 1 commit into
rollup:masterfrom
dmitrage:transform-hook-typings

Conversation

@dmitrage

Copy link
Copy Markdown
Contributor

I beleive it's a typo and it causes issue:

Argument of type 'String' is not assignable to parameter of type 'string'. 'string' is a primitive, but 'String' is a wrapper object. Prefer using 'string' when possible.

@lukastaegert lukastaegert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lukastaegert lukastaegert added this to the 0.60.7 milestone Jun 14, 2018
@lukastaegert
lukastaegert merged commit c071d56 into rollup:master Jun 14, 2018
calebeby referenced this pull request in Pigmice2733/scouting-frontend Jun 14, 2018
This Pull Request updates dependency [rollup](https://github.com/rollup/rollup) from `v0.60.6` to `v0.60.7`



<details>
<summary>Release Notes</summary>

### [`v0.60.7`](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#&#8203;0607)
[Compare Source](rollup/rollup@v0.60.6...v0.60.7)
*2018-06-14*
* Fix typing issue ([#&#8203;2269](`https://github.com/rollup/rollup/pull/2269`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@zenmumbler

Copy link
Copy Markdown

Oh and since you’ve enabled linting this class of errors can be caught by e.g. TSLint’s ‘ban’ collection of checks. Worth enabling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants