Remove duplicated rollup version output - #2325
Merged
Merged
Conversation
Contributor
Author
lukastaegert
approved these changes
Jul 12, 2018
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Looks good! My best guess is that this was an oversight as the first version printout was never visible when clearScreen was set.
Contributor
|
Probably, thanks for the fix @vladshcherbin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #2314
Hey, when trying to fix related issue I removed the first version output to remove duplication. There is a
STARTevent which does the same so the output is duplicated.Is there any case where
STARTevent doesn't fire or fires not first so you actually need the first version output? If there is, I will fix this another way.