Add memory perf metric along with time metrics - #2370
Merged
Conversation
Member
Author
|
Seems like metrics are bad parallelized for both time and memory. Will try to fix it in the next PR. |
guybedford
approved these changes
Aug 3, 2018
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this, its great to be tracking this footprint as we are starting to get occasional reports about large builds failing.
Member
Author
|
|
1 task
Member
|
Looks good. Minor note: pretty-bytes should have been a devDependency as it is automatically bundled into the CLI bundle. Created #2376 to fix this and some other things. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values looks a bit weird, but I think it's something like GC diagram