Rename option cacheExpiry -> experimentalCacheExpiry - #2401
Merged
Conversation
shellscape
requested changes
Aug 13, 2018
shellscape
left a comment
Contributor
There was a problem hiding this comment.
Sounds reasonable to me
shellscape
approved these changes
Aug 13, 2018
shellscape
left a comment
Contributor
There was a problem hiding this comment.
Gah, sorry wrong radio button.
lukastaegert
force-pushed
the
experimental-cache-expiry
branch
from
August 14, 2018 05:03
f94733b to
df9ec32
Compare
guybedford
pushed a commit
that referenced
this pull request
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Option renamed.
Please Describe Your Changes
I would prefer to make the new
cacheExpiryoption an experimental optionexperimentalCacheExpiryuntil we had some time to play around with this and are sure this is the way we want to configure cache expiry. Rationale:This PR also fixes some styling which shows me it is a good idea to enforce linting on the client side.