Skip to content

Rename option cacheExpiry -> experimentalCacheExpiry - #2401

Merged
lukastaegert merged 1 commit into
masterfrom
experimental-cache-expiry
Aug 14, 2018
Merged

Rename option cacheExpiry -> experimentalCacheExpiry#2401
lukastaegert merged 1 commit into
masterfrom
experimental-cache-expiry

Conversation

@lukastaegert

Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes (but only if we release current master before merging this)
  • no

If yes, please describe the breakage.
Option renamed.

Please Describe Your Changes

I would prefer to make the new cacheExpiry option an experimental option experimentalCacheExpiry until we had some time to play around with this and are sure this is the way we want to configure cache expiry. Rationale:

  • Being "experimental" signals this is in development and gives us more freedom to change how it works
  • We can safely document this as an experimental option so documentation is not forgotten again but it is not "set in stone"
  • Instead of counting runs, maybe it turns out measuring memory consumption or a combination of both is a better fit? Or it turns out this fine-grained control is not necessary and only very few values provided via a high-level interface work better here?

This PR also fixes some styling which shows me it is a good idea to enforce linting on the client side.

@guybedford guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@shellscape shellscape left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me

@shellscape shellscape left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, sorry wrong radio button.

@lukastaegert
lukastaegert force-pushed the experimental-cache-expiry branch from f94733b to df9ec32 Compare August 14, 2018 05:03
@lukastaegert
lukastaegert merged commit 9add3e3 into master Aug 14, 2018
@lukastaegert
lukastaegert deleted the experimental-cache-expiry branch August 14, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants