Throw better error messages for parse errors in non-JS files - #2466
Merged
Conversation
lukastaegert
force-pushed
the
better-json-error
branch
from
September 19, 2018 19:01
9557e0c to
d83b528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
One of the most common gotchas which quickly leads to people despairing is if one of their dependencies (or they themselves) imports a JSON file which leads to a syntax error, cf. e.g. #1652.
This patch subtly improves our error messages by checking for PARSE_ERRRORs whether they happened in a file with an extension that does not end with "js" (to catch both .js and .mjs). If so, the error message reads either
Unexpected token (Note that you need plugins to import files that are not JavaScript)or
Unexpected token (Note that you need rollup-plugin-json to import JSON files)specifically for .json files. Feedback e.g. on the wording of the messages is very much welcome!