Update TypeScript and fix type errors - #2488
Merged
Merged
Conversation
guybedford
reviewed
Oct 2, 2018
| let anotherPassNeeded = false; | ||
| this.included = true; | ||
| for (const declarator of this.declarations) { | ||
| if (declarator.include()) anotherPassNeeded = true; |
Contributor
There was a problem hiding this comment.
Interesting this is no longer needed.
Member
Author
There was a problem hiding this comment.
The dirty-flag is now managed via the context but it seems this file was overlooked. Nice that TypeScript found this!
guybedford
approved these changes
Oct 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Recently, the TypeScript test was failing on node 6 due to version drift caused by the lack of lock-file support. This updates TypeScript and fixes the underlying type issues.