Assign chunk IDs before creating outputBundle chunks - #2483
Merged
Conversation
guybedford
approved these changes
Sep 29, 2018
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Yup, this seems like how it should work!
Contributor
|
The CI failure seems to do with the assignment of numbers to named chunks with the same chunk name - I checked it out and it seems fine to update the tests to what is being output, and right as well that the first chunk ( |
Contributor
Author
|
Huh, it looks like it's only generating one chunk instead of three in that test? Investigating... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#2461
Description
The
chunkobject that is passed to therenderChunkhook (and which forms the properties of the output bundle object) contains, inter alia, animportsarray specifying the IDs of the external modules and chunks the chunk depends on.Currently, the loop that assigns the IDs to the chunk is the same as the loop that gets the imported IDs; consequently the imported IDs are frequently
undefined.This PR separates ID assignation into a separate loop.