Fix ExistingRawSourceMap type - #2507
Merged
Merged
Conversation
lukastaegert
approved these changes
Oct 14, 2018
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for digging into this, looks good!
Author
|
@lukastaegert thank you |
lukastaegert
pushed a commit
that referenced
this pull request
Oct 15, 2018
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The current definition of the (TypeScript)
ExistingRawSourceMaptype is wrong, the propertyversionis defined as "string" but the correct type is "number".This conflicts with libraries that returns sourceMap with the correct type, like the next version of gen-pug-source-map used in the rollup-plugin-pug.
This is a screenshot with such error:
After applying this fix the issue disappears.
See the Source Map Revision 3 Proposal