fix: experimentalPreserveModules not support in inlineDynamicImports … - #2560
Merged
Conversation
lukastaegert
approved these changes
Nov 17, 2018
lukastaegert
left a comment
Member
There was a problem hiding this comment.
Good catch! Usually I would ask for a test as this was broken before but since this is subject to be refactored in 1.0 anyway, I will as an exception merge this as it is.
This was referenced Aug 31, 2019
This was referenced Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…message
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Since
inlineDynamicImportswon't be truthy inelse if (inputOptions.experimentalPreserveModules), so moveINVALID_OPTIONabove.