Remove aggressive mode - #309
Merged
Merged
Conversation
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an interesting experiment, but I don't think it's viable. It's easy enough to change the behaviour of aggressive mode to pass #307, but not without pulling in a lot of code that we probably want to exclude.
The difference in bundle size between normal mode and aggressive-but-not-downright-negligent mode is too small to justify the increased complexity (in terms of both surface area for bugs, and the API). So I think we should just remove it altogether, and continue to investigate ways to identify chunks of code that are safe to remove.