Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Sandbye
force-pushed
the
fix/1067-workspace-include-globs-match-direc/trunk
branch
2 times, most recently
from
September 18, 2026 10:55
78dc2ad to
9f98be3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
A user-provided
workspace.includeglob matches directories, not packages, so adirectory with no
package.jsonwas resolved as a workspace package, inheritedthe root config and failed the build.
Matched directories are now dropped unless they hold a
package.jsonor atsdown.config.*. The filter is skipped whenworkspace.confignames anexplicit file, since there the config is named by the user and package-ness is
not the signal.
No workspace packages foundnow reports how many directorieswere skipped for that reason.
Scoped to the workspace half of #1067 on purpose: the error-message half is
already covered by #1068. #1069 took this same approach and was closed by its
author, who wrote that the implementation was "yours to take, rewrite, or drop";
this is a rewrite of it, with the explicit-config carve-out and unit tests.
Linked Issues
Closes #1067
Additional context
Behaviour change worth attention in review: a glob-matched directory without a
package is now skipped silently instead of failing later in the build.