Rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8>#1442
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 18.28% 18.27% -0.02%
==========================================
Files 127 127
Lines 9738 9738
==========================================
- Hits 1781 1780 -1
- Misses 7957 7958 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
12a8a98 to
be9fd92
Compare
be9fd92 to
5251f81
Compare
GitGab19
approved these changes
Feb 17, 2025
this is a more generic name, as this extra data could be used for other things and not only pool signature note: this renaming only happens on `roles_logic_sv2`, but not on SRI application layer (`roles`), where the field remains called `pool_signature`
5251f81 to
08b2523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1436
loosely inspired by 3f2815b from @Fi3 at #1248, but with a few corrections (and split into two different commits)
note: this renaming only happens on
roles_logic_sv2, but not on SRI application layer (roles), where the field remains calledpool_signature