remove assumption that coinbase scriptSig prefix contains only BIP34#1461
Merged
plebhash merged 1 commit intoFeb 25, 2025
Merged
Conversation
b0f0257 to
e59e1e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
- Coverage 18.34% 18.28% -0.06%
==========================================
Files 127 127
Lines 9723 9716 -7
==========================================
- Hits 1784 1777 -7
Misses 7939 7939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fi3
reviewed
Feb 6, 2025
e59e1e7 to
5d5d480
Compare
GitGab19
reviewed
Feb 18, 2025
eb08cfa to
9c7153e
Compare
GitGab19
approved these changes
Feb 19, 2025
jbesraa
reviewed
Feb 21, 2025
jbesraa
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I think a test should be added to examine the behavior when there is additional data in the scriptsig prefix beside bip34 data
Shourya742
requested changes
Feb 24, 2025
9c7153e to
4a59d63
Compare
4a59d63 to
55c01d2
Compare
This was referenced Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1460
builds on top of #1442