Skip to content

Correct username in vendor-agnostic metrics guide - #50739

Open
tk1ng wants to merge 1 commit into
masterfrom
correct-vendor-agnostic-metrics-guide
Open

tk1ng wants to merge 1 commit into
masterfrom
correct-vendor-agnostic-metrics-guide

Conversation

@tk1ng

@tk1ng tk1ng commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Problem

HTTP Basic Auth example snippet incorrectly lists username value as "username" instead of "service_role".

CleanShot 2026-09-22 at 11 43 11 AM

Solution

This is a small change to update that value.

Summary by CodeRabbit

  • Bug Fixes
    • Updated metrics scraping authentication to use the service role credential while continuing to use the Secret API key for the password.

@tk1ng
tk1ng requested a review from a team as a code owner September 22, 2026 16:44
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview, v0 Sep 22, 2026 4:46pm UTC
7 Skipped Deployments
Project Deployment Actions Updated
studio Ignored Ignored Sep 22, 2026 4:46pm UTC
design-system Skipped Skipped Sep 22, 2026 4:46pm UTC
kb Skipped Skipped Sep 22, 2026 4:46pm UTC
studio-self-hosted Skipped Skipped Sep 22, 2026 4:46pm UTC
studio-staging Skipped Skipped Sep 22, 2026 4:46pm UTC
ui-library Skipped Skipped Sep 22, 2026 4:46pm UTC
zone-www-dot-com Skipped Skipped v0 Sep 22, 2026 4:46pm UTC

Request Review

@supabase

supabase Bot commented Sep 22, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: supabase/supabase/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c4fc11b3-5874-4c0c-8fc0-b3126a51348f

📥 Commits

Reviewing files that changed from the base of the PR and between f65ee58 and eaee1a5.

📒 Files selected for processing (1)
  • apps/docs/content/guides/observability/metrics/vendor-agnostic.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Prometheus scrape configuration now uses service_role for HTTP Basic Auth. The Secret API key remains the password.

Changes

Observability authentication

Layer / File(s) Summary
Update scrape credentials
apps/docs/content/guides/observability/metrics/vendor-agnostic.mdx
The scrape configuration uses service_role as the username and retains the Secret API key as the password.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: awaseem

Merge Risk: ⚪ Minimal · up to eaee1

The guide now shows the required service_role username for privileged metrics scraping while retaining the Secret API key password. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the username correction in the vendor-agnostic metrics guide.
Description check ✅ Passed The description includes clear Problem and Solution sections that explain the incorrect username and the documentation fix. It does not include the template's Review instructions or Checklist sections…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@czenko czenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants