Skip to content

fix(marketing): hide leaderboard vertical guide lines - #7733

Merged
Kitenite merged 1 commit into
mainfrom
remove-leaderboard-grids
Sep 22, 2026
Merged

fix(marketing): hide leaderboard vertical guide lines#7733
Kitenite merged 1 commit into
mainfrom
remove-leaderboard-grids

Conversation

@Kitenite

@Kitenite Kitenite commented Sep 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

What & why

Remove the two vertical guide lines that overlap the background grid on /leaderboard. Add an optional guides prop to FactoryBackdrop, enabled by default, and disable it only on the leaderboard. Other pages retain their existing appearance.

How I tested it

  • Biome checks passed for both changed files; git diff --check passed.
  • Started marketing locally and opened /leaderboard in the Superset browser; confirmed the page rendered with no browser errors.
  • CI checks will be reviewed before merging, excluding the desktop build as requested.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • Same-repository PR; maintainer edits available

Summary by cubic

Removes the vertical guide lines that overlapped the background grid on the /leaderboard page.

Adds an optional guides prop to FactoryBackdrop (enabled by default) and disables it only on the leaderboard, so all other pages keep their existing appearance.

Written for commit 1fbe50d. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Updated the leaderboard page backdrop to display without guide lines, providing a cleaner visual presentation.
  • New Features
    • Added an option to show or hide guide lines in factory-style backdrops.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 68558c52-ad16-44ee-b314-a17d3f14ed45

📥 Commits

Reviewing files that changed from the base of the PR and between 9314d21 and 1fbe50d.

📒 Files selected for processing (2)
  • apps/marketing/src/app/[lang]/components/FactoryBackdrop/FactoryBackdrop.tsx
  • apps/marketing/src/app/[lang]/leaderboard/page.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

FactoryBackdrop now accepts an optional guides prop. The guide overlay remains enabled by default. The leaderboard disables the overlay with guides={false}.

Changes

Factory backdrop guide control

Layer / File(s) Summary
Conditional guide rendering
apps/marketing/src/app/[lang]/components/FactoryBackdrop/FactoryBackdrop.tsx		 Adds the optional guides prop with a default of true. The guide overlay renders only when the prop is enabled.
Leaderboard backdrop setting
apps/marketing/src/app/[lang]/leaderboard/page.tsx		 Passes guides={false} to disable guide lines on the leaderboard.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: harshithmullapudi

Merge Risk: ⚪ Minimal · up to 1fbe5

The leaderboard removes the overlapping guide lines while other backdrop consumers retain their existing appearance. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly describes the main change: hiding the leaderboard vertical guide lines.
Description check ✅ Passed The description includes the required What & why, How I tested it, and Checklist sections. It explains the change, records validation steps, and identifies the unchecked lint and typecheck items.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@Kitenite
Kitenite merged commit 1315a66 into main Sep 22, 2026
19 of 20 checks passed

This branch was successfully deployed

1 active deployment
preview — 1fbe50d2 Deployed Sep 22, 2026 by Kitenite via Deploy Docs #10195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kitenite