Updates to type alias for RayTracer and double-down namespace. - #786
Conversation
|
+1 for merging this in before the new DAGMC release |
|
Changes are showing up on CI when building DAGMC with Double Down |
gonuke
left a comment
There was a problem hiding this comment.
Just one little design query..
| std::string comp_name; | ||
| }; | ||
|
|
||
| class RayTracingInterface; |
There was a problem hiding this comment.
Is it possible to forward declare this in a namespace to avoid moving the include here? Not sure if that works, but it would be good to avoid includes in headers if possible.
… in DAGMC header. Thanks @gonuke!
Is this in a DAGMC action or an external project? |
Just a little external project. (Neutronics-workshop) |
|
I can't tell if @shimwell's concerns should block merging or not? |
No concerns about the PR over here. I'm keen to merge ASAP so I can get a few workflows running again |
I added a namespace to double-down in pshriwise/double-down#29 to protect from clashes of commonly-used class names (
Vec3f, etc.) and constants with other packages. These are breaking changes with DAGMC that are resolved in this PR. I figured it would be good to get this relatively small issue taken care of before our next DAGMC release.To ease potential concerns about any continued patterns along these lines, I'm about to do an initial release of double-down. No further breaking changes should happen before that, meaning that DAGMC can rely on specific versions of dd for testing going forward.
Description
Movement of double-down includes from
DagMC.cpptoDagMC.hpp.Motivation and Context
To maintain compatibility with the latest version of double-down.