More robust invocation of bash#787
Merged
Merged
Conversation
Rely on system to find correct bash
pshriwise
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use system method to find correct bash
Motivation and Context
The bash shell executable exists in different places on different systems. Rather than hard coding the path, use an accepted approach to resolve its location (albeit with a different hard coded path). Should resolve #783
Changes
This fixes a bug first identified in #783
Behavior
On some Linux distributions, the current behavior is that the PyNE amalgamation script does not run under CMake because bash is not found.