add limitation to cython version for MOAB compatibility & more selectivity about when some tests are run - #893
Merged
Merged
Conversation
Member
Author
|
Test of docker image building are here. |
Member
Author
|
This is separated out from #880 to separate docker building steps from testing steps |
Member
Author
|
This built successfully on my fork, and should be ready for review & merge. The last merge to |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Force cython version to be less than v3.0.0. At the same, be slightly more selective with triggers for some tests.
Motivation and Context
The versions of MOAB compatible with DAGMC are not compatible with cython 3+. pip installing cython recently changed to be v3, so we need to restrict the version.
Also, we are currently running tests on all platforms even when only changing the workflow on another platform.
Changes
bug fix for building dependencies
Limit when tests are run based on file paths.