Fix order of attribute initialization - #903
Conversation
|
Any thoughts on this @gonuke, @shimwell? https://github.com/svalinn/DAGMC/actions/runs/6039003224/job/16386661208 |
|
This is currently expected to fail. |
|
This test should no longer be run on PRs after my most recent PR (if you rebase?) |
I'd expect #902 to fail due to the additional flags used in CI, but this PR reorders the class attribute initialization so I'd expect it to pass. Am I missing something? |
|
This failing action is to test against new versions of Geant. I don't see it in your checks for this PR. |
|
Oh "this" being the CI build, not the PR itself. Though in the end I suppose the outcome is the same... All looks well on this PR though 👍🏻 Sorry for the cross-talk. |
gonuke
left a comment
There was a problem hiding this comment.
Thanks for this quick fix @pshriwise
Description
This fixes the issue referenced in #902 and is shown in this CI build failure for that PR.
Motivation and Context
Enables builds of DAGMC with MOOSE apps without failure.
Changes
Small refactor of the metadata class.