Conversation
Fixes sveltejs#17072 Co-Authored-By: Aiden <aiden@weco.ai>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/7fa6caa607afda53dce4da2c2f3c22568b13e5d6Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 7fa6caa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes sveltejs#17072 Co-Authored-By: Aiden <aiden@weco.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17072
form.fields.*.dirty()now clears when a value is restored to the form’s mounted baseline. This covers UI edits and programmatic nested updates while preserving touched state and the existing default-value behavior. Resetting or remounting the form establishes a fresh baseline.With the same supported fixtures, pristine code passes 3 of the 15 selected browser cases and fails 12 dirty-state assertions; this change passes all 15. The original five requirement and guard cases improve from 2 passing to 5 passing.
Weco research trajectory includes the rejected attempts and their source snapshots. The final supported-fixture baseline and candidate are steps 4 and 5.
Local validation: formatting and lint passed; the full workspace type check passed with workspace concurrency set to 1; Kit unit tests recorded 779 passed, 0 failed and 110 pending; the 15 selected Playwright cases passed without retries, skips or flakes. Generated types and a minor
feat:changeset are included. The fullpnpm testsuite was not run locally.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits