Repository navigation
fix: decode numeric character references in the tertiary ideographic and supplementary private use planes - #18903
Open
NgoQuocViet2001 wants to merge 1 commit into
Open
NgoQuocViet2001 wants to merge 1 commit into
NgoQuocViet2001 wants to merge 1 commit into
Conversation
…and supplementary private use planes
|
Install the latest version of pnpm add https://pkg.svelte.dev/svelte/c/7fbae3078429025631236476838291b04e757951Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 7fbae30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_codeonly lets code points above U+FFFF through for planes 1-2 and part of plane 14, so every other valid code point becomes U+0000. That includes plane 3 (CJK Extension G/H, e.g.𰻝𰻝) and the supplementary private use planes 15-16 that icon fonts use (e.g.󰀁). The spec only replaces 0, surrogates and values above 0x10FFFF.For
<span title="𰻝">𰻝 󰀁</span>, the server output on main is<span title="\u0000">\u0000 \u0000</span>, so the text renders empty and the title shows replacement characters (client output has the same NUL in the attribute). With this change they decode to the actual characters. I kept per-plane ranges like #15823 did for plane 14; letting everything up to 0x10FFFF through would also work if you prefer that.pnpm test runtime-legacy -t html-entities: dom, hydrate and ssr fail on main, 15/15 pass with the fixpnpm test(reran the suites that timed out on their own): all passpnpm check,eslintandprettier --check .: cleanBefore submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint