Draft: feat(tailscale): New app - #1223
Draft
brettpetch wants to merge 9 commits into
Draft
brettpetch wants to merge 9 commits into
brettpetch wants to merge 9 commits into
Conversation
brettpetch
marked this pull request as draft
April 15, 2025 01:20
Comment on lines
+13
to
+14
| echo_query "What would you like your machine hostname to be on your tailnet?" "$(hostname)" | ||
| read -re ts_hostname |
Member
There was a problem hiding this comment.
Would be cool if we could also optionally get these via env vars, makes testing easier
| echo_error "Tailscale is already installed. Please remove /install/.tailscale.lock to reinstall." | ||
| fi | ||
|
|
||
| curl -fsSL https://tailscale.com/install.sh | sh >> $log 2>&1 |
Member
There was a problem hiding this comment.
Would appreciate having these wrapped in functions
| fi | ||
|
|
||
| touch /install/.tailscale.lock | ||
| echo_progress_done "Tailscale installed and configured successfully." |
Member
There was a problem hiding this comment.
It might be nice to send users to the docs for how to invite their users if they have any
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following PR commits the ability to use tailscale.
Fixes issues:
Proposed Changes:
Change Categories
Checklist
developbranch and the PR is targetting thedevelopbranchTest scenarios
Architectures
amd64armhfarm64✅❎ Passed
🛠🛠 TODO
❌❌ Currently failing