Skip to content

Add glob pattern to eccentricity control #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsvu merged 1 commit into from
Feb 5, 2025
Merged

Add glob pattern to eccentricity control #6465

nilsvu merged 1 commit into from
Feb 5, 2025

Conversation

@vtommasini
Copy link
Contributor

@vtommasini vtommasini commented Jan 30, 2025

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

nilsvu
nilsvu requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove my two commits from this branch (because they're already in #6461). Also please edit your commit message to make it descriptive.

@vtommasini vtommasini force-pushed the develop branch 3 times, most recently from 54a8040 to 82a2408 Compare January 31, 2025 04:55
@nilsvu
Copy link
Member

nilsvu commented Feb 3, 2025

Please just fix your commit message so it's descriptive.

Add glob pattern to eccentricity control to take
811961c 
in reduction files from all segment directories
@nilsvu nilsvu merged commit bb4d647 into sxs-collaboration:develop Feb 5, 2025
23 of 24 checks passed
@nilsvu nilsvu changed the title Eccentricity Control Full Run Test Add glob pattern to eccentricity control Feb 5, 2025
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsvu nilsvu nilsvu approved these changes

Assignees

No one assigned

Labels

cli/pybindings Command line interface & Python bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtommasini @nilsvu