Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jan 27, 2025

Proposed changes

Make sure that ecc control iterations also do ID control (control total masses to be 1). This didn't work as intended before because the ID input file from the last control iteration was loaded, which had control=False set.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe merged commit 0e5065b into sxs-collaboration:develop Jan 31, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants