Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request refactors the Status enumeration to a scoped enum class within the studio::Instance class and updates its usage across instance.cpp. A critical issue was identified in safe_close() where the enum keyword remains in a variable declaration; this is invalid syntax for an enum class and will result in a compilation error.
| enum Status status = save(); | ||
| if (status == STATUS_OK) break; | ||
| else if (status == STATUS_CANCEL) return false; | ||
| if (status == Status::STATUS_OK) |
There was a problem hiding this comment.
The declaration of status on line 945 (context) still uses the enum keyword (e.g., enum Status status = save();). Since Status has been refactored to an enum class, this syntax is no longer valid in C++ and will cause a compilation error. The enum keyword must be removed from the variable declaration.
No description provided.