Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request updates get_current_working_directory() in synfig-core/src/synfig/os.cpp to support the OWD environment variable for AppImages and refactors the existing PWD check. The review feedback correctly points out that the function must return an absolute path, and suggests verifying that the paths resolved from OWD and PWD are absolute using path.is_absolute() to prevent breaking pathname resolutions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Oh, an actual good code review... I thought about the issue but stupidly couldn't get a solution. XD |
It should now allow to launch the AppImage with a SIF file as argument. ```sh $ synfig.appimage myanimation.sifz ```
2534ade to
f502af4
Compare
|
Normally under Linux, we should use Also, as appimage requires the FQN, and Working solutions:
And of course the same system to call
|
|
@BobSynfig So my PR doesn't work? |
It should now allow to launch the AppImage with a SIF file as argument.