Repository navigation
Equal Opensource Card Sizes - #516
saiteja13427 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
|
|
||
| .repo-name { | ||
| white-space: nowrap; | ||
| text-overflow: ellipsis; |
There was a problem hiding this comment.
Is there a reason to remove the ellipsis here?
There was a problem hiding this comment.
Yeah, because of changing to flex, ellipsis will not work. If we want ellipsis, then we need to make some more changes.
There was a problem hiding this comment.
I tried it and it breaks the layout into a long single card (which is probably how it was before your changes too).
We can change the layout container to use grid or add a max width to the card so it doesn't extend into a single long card. This would also solve the ellipsis problem as the container would now have a specified width so the p tag can just be width: 100% now
There was a problem hiding this comment.
Sure I will do that and push!
| <div className="repo-left-stat"> | ||
| {repo.node.primaryLanguage !== null && ( | ||
| <div className={isDark ? "dark-card-mode repo-card-div" : "repo-card-div"}> | ||
| <Fade bottom duration={1000} distance="20px"> |
There was a problem hiding this comment.
Why is 'Fade' not the parent anymore?
If there's no particular reason for the reorder, can we revert? I'd like to keep the same pattern across components for consistency
There was a problem hiding this comment.
Ya in that case I think we can revert this, shall I make it the parent again and push a commit?
There was a problem hiding this comment.
Yeah that'd be great for consistency
|
Are you still working on this @saiteja13427 ? |
|
@kartikcho Yes, I was stuck with some other work. Will push the changes today or tomorrow for sure |
|
Sure np, thanks for the heads up! |
|
@saiteja13427 Are you still working on it or should I close it. |
|
@saadpasta I think we can close this PR for now. I will raise a new PR with the changes in the suggested way! |
Makes all the opensource project card sizes equal.
Changes
Addresses Issue #490
@kartikcho Do have a look!
Note: Seems like the vercel auto deployment is not configured to show up the opensource cards, so you will have to test it locally i guess.