Skip to content

/v2/commitment convert - #966

Open
wagnerd3 wants to merge 7 commits into
masterfrom
v2_commitment_convert
Open

/v2/commitment convert#966
wagnerd3 wants to merge 7 commits into
masterfrom
v2_commitment_convert

Conversation

@wagnerd3

@wagnerd3 wagnerd3 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Again, I suggest going commit by commit - I tried my best to structure the changes. 👉🏻👈🏻🥺

@wagnerd3
wagnerd3 requested a review from a team as a code owner October 5, 2026 13:33
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

⚠️ Note: Baseline coverage from master branch is not available (artifact may be expired). Showing current coverage for changed files only.

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/limes/internal/api/api_v2 89.70% (+89.70%) 🌟
github.com/sapcc/limes/internal/api/reports_v2 94.34% (+94.34%) 🌟
github.com/sapcc/limes/internal/audit 96.83% (+96.83%) 🌟
github.com/sapcc/limes/internal/core 85.74% (+85.74%) 🌟
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/limes/internal/api/api_v2/commitment_convert.go 93.53% (+93.53%) 1251 (+1251) 1170 (+1170) 81 (+81) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_create.go 89.38% (+89.38%) 1017 (+1017) 909 (+909) 108 (+108) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_delete.go 97.44% (+97.44%) 351 (+351) 342 (+342) 9 (+9) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_helpers.go 88.60% (+88.60%) 1026 (+1026) 909 (+909) 117 (+117) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_merge.go 88.30% (+88.30%) 846 (+846) 747 (+747) 99 (+99) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_patch.go 95.40% (+95.40%) 783 (+783) 747 (+747) 36 (+36) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_receive.go 92.41% (+92.41%) 1305 (+1305) 1206 (+1206) 99 (+99) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_renew.go 88.24% (+88.24%) 765 (+765) 675 (+675) 90 (+90) 🌟
github.com/sapcc/limes/internal/api/api_v2/commitment_split.go 89.29% (+89.29%) 756 (+756) 675 (+675) 81 (+81) 🌟
github.com/sapcc/limes/internal/api/api_v2/core.go 81.98% (+81.98%) 1548 (+1548) 1269 (+1269) 279 (+279) 🌟
github.com/sapcc/limes/internal/api/reports_v2/info.go 97.04% (+97.04%) 1521 (+1521) 1476 (+1476) 45 (+45) 🌟
github.com/sapcc/limes/internal/apideclarations/apiv2/doc.go 0.00% (ø) 0 0 0
github.com/sapcc/limes/internal/apideclarations/apiv2/resources/commitment.go 0.00% (ø) 0 0 0
github.com/sapcc/limes/internal/apideclarations/apiv2/resources/info.go 0.00% (ø) 0 0 0
github.com/sapcc/limes/internal/audit/audit.go 96.83% (+96.83%) 441 (+441) 427 (+427) 14 (+14) 🌟
github.com/sapcc/limes/internal/core/commitment_behavior.go 91.26% (+91.26%) 927 (+927) 846 (+846) 81 (+81) 🌟
github.com/sapcc/limes/internal/test/common_fixtures/fixture_paths.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/limes/internal/api/api_v2/commitment_convert_test.go
  • github.com/sapcc/limes/internal/api/api_v2/commitment_create_test.go
  • github.com/sapcc/limes/internal/api/api_v2/commitment_receive_test.go
  • github.com/sapcc/limes/internal/api/api_v2/commitment_split_test.go
  • github.com/sapcc/limes/internal/api/api_v2/commitment_test.go
  • github.com/sapcc/limes/internal/api/api_v2/info_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wagnerd3