Fix ARC evaluation label mapping for numeric choice IDs - #2
Merged
Merged
Conversation
Collaborator
|
Thanks for catching this @grp06 — confirmed the bug with HF dataset (22/1172 ARC-Challenge test rows have numeric answerKeys). For this codebase I'd like to keep the change minimal — would you mind dropping the helper extraction and the test file, and just changing the lambda to: row_to_doc_fn=lambda r: MCQDoc(r['question'], r['choices']['text'], r['choices']['label'].index(r['answerKey']))We don't have a test harness set up here yet, so the stubs in tests/test_benchmarks.py would be the only test in the repo and it'd be a maintenance burden until we add a proper one. Happy to merge once it's down to the one-line change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note