Follow-up to #170: cover labels on the with-comments query path#241
Merged
Conversation
#170 adds `labels` to `issue view --json` by selecting them in both GetIssueDetails and GetIssueDetailsWithComments. Its dedicated labels-with-content test only exercises the --no-comments (GetIssueDetails) path; the with-comments path was covered only with empty labels. Add a --json (with comments) test carrying real labels so both fetchIssueDetailsRaw code paths are verified to surface labels — the consistency both were meant to guarantee.
schpet
marked this pull request as ready for review
July 11, 2026 21:25
schpet
force-pushed
the
oss-pr-lander/170
branch
from
July 11, 2026 21:25
60e0d3e to
1436392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft follow-up to #170. Do not merge before #170. #170's branch was conflicting with
main(it predated a refactor that movedfetchIssueDetails' return type to the codegen-derivedFetchedIssueDetailsand evolved the issue-detail queries); I resolved it by merging currentmaininto the PR branch — taking main's structure and re-applying thelabelsselection to both queries — and pushed that merge to the fork, so #170 is mergeable again.This follow-up adds one test: #170 selects
labelsin bothGetIssueDetailsandGetIssueDetailsWithComments, but its labels-with-content test only exercised the--no-comments(GetIssueDetails) path. This adds a--json(with comments) test carrying real labels so bothfetchIssueDetailsRawpaths are verified to surface labels — the consistency both were meant to guarantee.Credit to @RengarLee for #170.