Follow-up to #236: fail hard on fmt errors, trim abort output, render SKILL.md first#242
Merged
Conversation
… SKILL.md first Corrective delta on top of #236's generator hardening: - deno fmt failure is now fatal instead of a logged warning; unformatted committed docs would otherwise break `deno fmt --check` in CI. - The top-level error boundary prints a concise message instead of the raw error (and its stack trace) on every abort path. - SKILL.md is rendered from its template before writeReferences prunes any stale docs, so a missing or broken template aborts before touching the references directory.
schpet
force-pushed
the
oss-pr-lander/236
branch
from
July 14, 2026 03:51
bd42812 to
48c5b5c
Compare
schpet
marked this pull request as ready for review
July 14, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #236. A small corrective delta stacked on top of that PR's generator hardening; it will be rebased down to only the delta once #236 lands.
This delta was blind-planned: two independent planners designed the generator fix from a solution-stripped problem statement (without seeing #236), and both independently flagged the three gaps below that #236 left open.
What this changes in
skills/linear-cli/scripts/generate-docs.tsdeno fmtfailure is now fatal instead of a logged warning. The format step runs after the docs are written, so a silent failure would leave unformatted docs that breakdeno fmt --checkin CI once committed.Error: <message>) instead of the raw error object and its stack trace, on every abort path (missing binary, failed help fetch, fmt failure).SKILL.mdis rendered from its template beforewriteReferencesprunes any stale docs, so a missing or broken template aborts before the references directory is touched — extending refactor(skill-docs): harden generator and make output deterministic #236's own "write before prune / abort before write" invariant to the template read.None of these change the generated doc output — they are pure control-flow/error-handling.
deno task generate-skill-docsremains idempotent.