Fallback for randomUUID when not available (non secure context) - #472
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 33da27d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
michaeltaranto
approved these changes
Feb 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! First of all thanks for the awesome tool!
When updating to the latest version of playroom we've come to an error when trying to use it over the LAN network, in my case: http://192.168.1.36:9000/#?code=N4Igxg9gJgpiBcIA8AhAhgJwAQHoB8IAvkA. randomUUID function used to generate playroom ids is only available in secure contexts or trustworthy origins, so an error is thrown.
I created this little PR where we fallback to a uuidv4 generator function when randomUUID is not available. I used this implementation because I didn't dig much into your code, but perhaps an easier one could be used.
Issue: #473
Before:
After:
Hoping to get your feedback soon!