Conversation
__getMinFileOffset() would return 0 on older BAI versions, causing crashes when trying to call readRecord after jumping to the given offset.
Member
|
@smehringer can you review this? |
Contributor
|
@smehringer can you have a look into it? |
Contributor
|
@smehringer could you have a look at it? |
smehringer
removed their request for review
September 18, 2019 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adressing issue #2319.
__getMinFileOffset() would return 0 on older BAI versions, causing
crashes when trying to call readRecord after jumping to the given
offset.